Cherry-pick #15545 to 7.x: [Filebeat] Handle error message in handleS3Objects function #15558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle error message in handleS3Objects function * remove s3Context.Fail and use setError and done instead * Add changelog (cherry picked from commit 2228af4)
fearful-symmetry
approved these changes
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15545 to 7.x branch. Original message:
When error occurred from
reader.ReadString, error message originally got returned from callinghandleS3Objectsfunction but did not store the error into the error channel successfully. With this change, error message will be passed into the error channel and the same error channel will be closed.