[Metricbeat]Log prometheus errors instead of parsing families #15712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresrc
added
[zube]: Inbox
Team:Platforms
exekias
reviewed
Jan 28, 2020
| if p.logger.IsDebug() { | ||
| bodyBytes, err := ioutil.ReadAll(resp.Body) | ||
| if err == nil { | ||
| p.logger.Debug("error received from prometheus endpoint: ", string(bodyBytes)) |
There was a problem hiding this comment.
do you expect this body to be large? as this error is fairly important we could consider showing it by default. With some trimming if needed
There was a problem hiding this comment.
don't expect large errors payloads there.
will change it to show description without debug enabled
exekias
approved these changes
Jan 29, 2020
jsoriano
pushed a commit
to jsoriano/beats
that referenced
this pull request
Feb 10, 2020
…c#15712) * log prometheus errors instead of parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #15709
Some users have been reporting errors fetching prometheus endpoints that include logs stating format errors decoding families.
Most probably metricbeat's prometheus helper has been trying to parse errors received as metric families. This PR adds the HTTP status code to the error sent upstream from the helper and also allows for writing the error body to log when debug is enabled.