[7.x][Heartbeat] Support for multiple status codes #13595 (#15587) #15720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15587) Allow for multiple status codes in config. Fixes elastic#13595 (cherry picked from commit 4a408e5)
andrewvc
added
enhancement
backport
Heartbeat
Team:obs-ds-hosted-services
|
Pinging @elastic/uptime (:uptime) |
|
@andrewvc Wouldn't this be a breaking change? Or will the old syntax of a single status code still work? Asking since this PR targets a minor release branch. |
|
Also, should there be a CHANGELOG entry for this change (in |
|
@ycombinator the old syntax still works a single value gets coerced into an array, but good looking out for the changelog! That didn't make it into master either. I'll make a separate changelog only PR for master then merge that into here to keep the number of PRs down. |
andrewvc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for multiple status codes in config. Fixes #13595
Backport of #15587