Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enabling golang integration tests #15819

Merged
merged 14 commits into from
Jan 29, 2020
Merged

Re-enabling golang integration tests #15819

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6286301
Adding debugging
ycombinator Jan 24, 2020
4c0e33e
Still debugging
ycombinator Jan 24, 2020
0f2af2c
Add deps for integration tests
ycombinator Jan 24, 2020
a01beab
Making progress, I think :)
ycombinator Jan 24, 2020
cb2ed6e
Testing
ycombinator Jan 24, 2020
23bff34
Try a different way of passing the env var
ycombinator Jan 24, 2020
efa0c46
Revert docker info change
ycombinator Jan 24, 2020
9ac6477
Removing debugging statements
ycombinator Jan 24, 2020
1e9c7c6
Ensure "AND"ing of build tags
ycombinator Jan 24, 2020
4375bb3
Don't explicitly pass BEATS_DOCKER_INTEGRATION_TEST_ENV
ycombinator Jan 28, 2020
bef6960
Move mage goIntegTest usage to metricbeat makefile
ycombinator Jan 28, 2020
7aaaeec
Fixing up comment
ycombinator Jan 28, 2020
d530cb3
Forgot the line continuation mark
ycombinator Jan 28, 2020
bef4f89
Pass the env var
ycombinator Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion libbeat/scripts/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,12 @@ integration-tests-environment: prepare-tests build-image
#
# This will make docker-compose command to display the logs on stdout on error, It's not enabled
# by default because it can create noise if the test inside the container fails.
${DOCKER_COMPOSE} run beat make integration-tests RACE_DETECTOR=$(RACE_DETECTOR) DOCKER_COMPOSE_PROJECT_NAME=${DOCKER_COMPOSE_PROJECT_NAME}
${DOCKER_COMPOSE} run \
-e RACE_DETECTOR=$(RACE_DETECTOR) \
-e DOCKER_COMPOSE_PROJECT_NAME=${DOCKER_COMPOSE_PROJECT_NAME} \
-e TEST_ENVIRONMENT=${TEST_ENVIRONMENT} \
-e BEATS_DOCKER_INTEGRATION_TEST_ENV=1 \
Copy link
Contributor Author

@ycombinator ycombinator Jan 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is what makes the integration tests run again in CI. But I'm not 100% sure if this is the right fix or the right place to make this fix. Any thoughts @urso @mtojek?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I focused mostly on the continuously failing integration tests for x-pack/metricbeat and assumed that the execution path at this level is same for both. Sorry about that.

I see test output in the Travis CI log proving it's working now. I don't know about any requirements that prevent you from merging this change. Thanks!

side note:
It would be useful if these magic envs are somewhere documented (what are they for, why not autodiscovered): BEATS_DOCKER_INTEGRATION_TEST_ENV, TEST_ENVIRONMENT, etc.

beat make integration-tests

# Runs the system tests
.PHONY: system-tests
Expand Down
3 changes: 2 additions & 1 deletion metricbeat/module/windows/perfmon/perfmon_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
// specific language governing permissions and limitations
// under the License.

// +build integration windows
// +build integration
// +build windows
Copy link
Contributor Author

@ycombinator ycombinator Jan 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this change this integration test was being run on Linux. Multiple build tags on the same line are combined with a logical OR whereas multiple build tags on different lines are combined with an "AND". We want the latter effect for this test.


package perfmon

Expand Down