Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Memcached: add support for Unix socket #15822

Merged
merged 2 commits into from
Jan 27, 2020
Merged

[Metricbeat] Memcached: add support for Unix socket #15822

merged 2 commits into from
Jan 27, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Jan 24, 2020 •
edited
Loading

This PR adds support for Unix socket in the Memcached Metricbeat module.

Issue: #13685

How to test this PR locally

  1. Boot up memcached instance with Unix socket (AFAIR -s /path_to_socket).
  2. Enable memcached metricbeat module.
  3. Configure module to use hosts: [ "unix://path_to_socket" ].
  4. Start metricbeat with -e -d processors and observe events flow.

@mtojek mtojek requested a review from a team as a code owner January 24, 2020 14:38
@mtojek mtojek added Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. labels Jan 24, 2020
@fearful-symmetry
Copy link
Contributor

Do we want to add any new config options to the reference configs?

@mtojek
Copy link
Contributor Author

mtojek commented Jan 27, 2020

Do we want to add any new config options to the reference configs?

I've updated the PR. No additional config options are exposed.

@mtojek mtojek requested review from jsoriano and a team January 27, 2020 06:49
jsoriano
jsoriano approved these changes Jan 27, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mtojek mtojek merged commit 4a072f7 into elastic:master Jan 27, 2020
mtojek added a commit to mtojek/beats that referenced this pull request Jan 27, 2020
@mtojek
[Metricbeat] Memcached: add support for Unix socket (elastic#15822)
ba2f767 
* Memcached: add support for Unix socket

* Use single host field for URI

(cherry picked from commit 4a072f7)
@mtojek mtojek mentioned this pull request Jan 27, 2020
Merged
@mtojek mtojek added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Jan 27, 2020
mtojek added a commit that referenced this pull request Jan 27, 2020
@mtojek
Cherry-pick #15822 to 7.x: [Metricbeat] Memcached: add support for Un…
cd1808e 
…ix socket (#15858)

* [Metricbeat] Memcached: add support for Unix socket (#15822)

* Memcached: add support for Unix socket

* Use single host field for URI

(cherry picked from commit 4a072f7)

* Fix: changelog
@mtojek mtojek added the test-plan Add this PR to be manual test plan label Mar 16, 2020
@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Mar 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtojek @fearful-symmetry @elasticmachine @jsoriano @andresrc