-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Agent] Inject index with sane defaults to configuration #15852
Conversation
Pinging @elastic/ingest (Project:fleet) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I am going to approve this. the final format will be a bit different see https://gist.github.com/ph/c7a83c8dee58a90051ceb6b0c2cbad5b not final and not ready for implementation
metricbeat/module/system/network_summary/network_summary_test.go
Outdated
Show resolved
Hide resolved
Tested with this config. careful outputs:
default:
type: elasticsearch
api_key: VuaCfGcBCdbkQm-e5aOx:ui2lp2axTNmsyakw9tvNnw
hosts: ["localhost:9200"]
ca_sha256: "7lHLiyp4J8m9kw38SJ7SURJP4bXRZv/BNxyyXkCcE/M="
monitoring:
type: elasticsearch
api_key: VuaCfGcBCdbkQm-e5aOx:ui2lp2axTNmsyakw9tvNnw
hosts: ["localhost:9200"]
ca_sha256: "7lHLiyp4J8m9kw38SJ7SURJP4bXRZv/BNxyyXkCcE/M="
datasources:
- use_output: default
inputs:
- type: logs
streams:
- dataset: nginx.acccess
paths: /var/log/nginx/access.log
- type: metrics/nginx
streams:
- dataset: nginx.stub_status
metricset: stub_status
settings.monitoring:
enabled: true
use_output: monitoring
logs: true
management:
host: "localhost"
config:
reload: 123
download:
sourceURI: "https://artifacts.elastic.co/downloads/beats/"
target_directory: "/{user_home}/elastic/downloads"
timeout: 30s
pgpfile: "/{user_home}/elastic/elastic.pgp"
install_path: "/{user_home}/elastic/install"
process:
min_port: 10000
max_port: 30000
spawn_timeout: 30s
retry:
enabled: true
retries_count: 3
delay: 30s
max_delay: 5m
exponential: false
|
Build on top of: #15809
Added one extra rule for injecting index into inputs based on provided type and detected namespace/dataset type.
Other option was to use decorator but at the time of decorating there are already some pieces of config missing.
Draft until final configuration format is settled and mentioned PR is in, but READY for review.
It overwrites index specified in input.
Fixes: #15690
Fixes: #15691