Cherry-pick #15708 to 7.x: Fix issue where default go logger is not discarded when either * or stdout is selected. #15880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdout is selected. (elastic#15707) * Disable default logger when stdlog or the default all selector is not enabled. * Fix issue where default go logger is not discarded when either * or stdout is selected. Fix elastic#10251. * Change logic to always discard unless in debug and when all or stdlog is selected. Add more tests. * Fix comments. * Add changelog entry. (cherry picked from commit 1838734)
kaiyan-sheng
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #15708 to 7.x branch. Original message:
What does this PR do?
Fix issue where default go logger is not discarded when either * or stdout is selected.
Why is it important?
Prevents other imported modules from outputting log messages.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesRelated issues