Remove redundant wildcard after %{SPACE} patterns #15900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
module
review
Filebeat
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
andresrc
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
ycombinator
force-pushed
the
fb-es-fix-grok-redundant-wildcards
branch
from
e8772ca
to
8e42ac3
Compare
kvch
approved these changes
Jan 31, 2020
This was referenced Jan 31, 2020
ycombinator
removed
v6.8.7
needs_backport
ycombinator
added a commit
that referenced
this pull request
Feb 5, 2020
ycombinator
added a commit
that referenced
this pull request
Feb 5, 2020
ycombinator
added a commit
that referenced
this pull request
Feb 6, 2020
|
We've upgraded ElasticSearch AND all our FileBeats from 7.3 to 7.6 today and are suddenly having this issue. Is there any way to tell which filebeat is causing the issue? |
2 tasks
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
… (elastic#15996) * Remove redundant wildcard after %{SPACE} patterns (elastic#15900) * Remove redundant wildcard after %{SPACE} patterns * Adding CHANGELOG entry * Cleaning up CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It improves the grok patterns used in the
elasticsearchFilebeat module's ingest pipelines. Specifically, it removes any?or*wildcards after the%{SPACE}pattern, since that pattern already incorporates the*wildcard.Why is it important?
Without this change, when the module's ingest pipelines are setup in Elasticsearch, the Elasticsearch server logs get flooded with warnings like so:
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksThere are existing golang integration tests.Related issues