Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.6] Re-enabling golang integration tests (#15819) #15934

Merged
merged 1 commit into from
Jan 30, 2020
Merged

[7.6] Re-enabling golang integration tests (#15819) #15934

merged 1 commit into from
Jan 30, 2020

Conversation

ycombinator
Copy link
Contributor

Backports the following commits to 7.6:

@ycombinator
Re-enabling golang integration tests (#15819)
8b051b7 
* Adding debugging

* Still debugging

* Add deps for integration tests

* Making progress, I think :)

* Testing

* Try a different way of passing the env var

* Revert docker info change

* Removing debugging statements

* Ensure "AND"ing of build tags

* Don't explicitly pass BEATS_DOCKER_INTEGRATION_TEST_ENV

* Move mage goIntegTest usage to metricbeat makefile

* Fixing up comment

* Forgot the line continuation mark

* Pass the env var
@ycombinator ycombinator requested a review from a team as a code owner January 29, 2020 15:30
@ycombinator ycombinator merged commit 2f4ce5a into elastic:7.6 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycombinator @kaiyan-sheng @andresrc