Make use of secure port when accessing Kubelet API #16063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
ChrsMark
added
enhancement
in progress
ChrsMark
added
Team:Integrations
exekias
reviewed
Feb 4, 2020
Comment on lines
82
to
83
| # If using Red Hat OpenShift remove the previous hosts entry and | ||
| # uncomment these settings: |
There was a problem hiding this comment.
this comment needs rewording, right?
exekias
suggested changes
Feb 4, 2020
|
this will need a changelog |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
|
Also these changes might apply to ECK manifests and helm-chart1 helm-chart2 maybe? |
exekias
approved these changes
Feb 5, 2020
Yes! good catch |
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Feb 5, 2020
(cherry picked from commit b9791ad)
5 tasks
ChrsMark
removed
the
needs_backport
ChrsMark
added a commit
that referenced
this pull request
Feb 5, 2020
sebgl
pushed a commit
to elastic/cloud-on-k8s
that referenced
this pull request
Feb 6, 2020
What does this PR do? This PR switches Metricbeat k8s manifests and docs to point to Kubelet secure port over https instead of the insecure port. Why is it important? Insecure port of Kubelet (10255/TCP) is now less common and discouraged and also in most cases it is not enabled by default (requiring to restart kubelet with --read-only-port flag) Related to elastic/beats#16063
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Mar 9, 2020
(cherry picked from commit b9791ad)
5 tasks
ChrsMark
added a commit
that referenced
this pull request
Mar 9, 2020
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR switches Metricbeat k8s manifests and docs to point to Kubelet secure port over https instead of the insecure port.
Why is it important?
Insecure port of Kubelet (10255/TCP) is now less common and discouraged and also in most cases it is not enabled by default (requiring to restart
kubeletwith--read-only-portflag)Checklist
I have added tests that prove my fix is effective or that my feature worksRelated issues