Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable netinfo in add metadata processors #16077

Merged
merged 7 commits into from
Feb 18, 2020
Merged

Enable netinfo in add metadata processors #16077

merged 7 commits into from
Feb 18, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 4, 2020 •
edited by andresrc
Loading

What does this PR do?

Enable netinfo in add_host_metadata and add_observer_metadata processors by default.

Why is it important?

This network information metadata is used in observability solutions.

This change shouldn't break backwards compatibility or produce any conflict as the added fields are in ECS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

How to test this PR locally

  • Run a beat with the add_host_metadata processor without any options.
  • Check that all events contain host.ip and host.mac fields.

Related issues

@jsoriano jsoriano requested review from a team as code owners February 4, 2020 17:28
@jsoriano jsoriano self-assigned this Feb 4, 2020
@jsoriano @DanRoscigno
Enable netinfo in add_host_metadata processor
05cfe97 
Co-Authored-By: DanRoscigno <dan@roscigno.com>
@jsoriano jsoriano mentioned this pull request Feb 4, 2020
Closed
@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.7.0 labels Feb 4, 2020
andrewkroh
andrewkroh approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's close to breaking change, but won't cause any sort of conflict. Users that want to continue with the old behavior must add back the netinfo.enabled: false.

@jsoriano
Copy link
Member Author

jsoriano commented Feb 6, 2020 •
edited
Loading

LGTM. It's close to breaking change, but won't cause any sort of conflict. Users that want to continue with the old behavior must add back the netinfo.enabled: false.

Yep, I had similar thoughts #15347 (comment)

@jsoriano
Copy link
Member Author

jsoriano commented Feb 6, 2020

I have made the same change in add_observer_metadata for consistency. I would find weird to see one adding this data by default while the other doesn't. Opinions?

@jsoriano jsoriano changed the title Enable netinfo in add_host_metadata processor Enable netinfo in add metadata processors Feb 6, 2020
@jsoriano
Copy link
Member Author

jsoriano commented Feb 6, 2020 •
edited
Loading

Failing test is also failing in master, it seems to be related to a change in ES 8.0 snapshots (#16139).

@jsoriano jsoriano merged commit 4ea0f91 into elastic:master Feb 18, 2020
@jsoriano jsoriano deleted the netinfo-enabled-by-default branch February 18, 2020 19:23
jsoriano added a commit to jsoriano/beats that referenced this pull request Feb 18, 2020
@jsoriano
Enable netinfo in add metadata processors (elastic#16077)
76dd7c8 
Enable netinfo in add_host_metadata and add_observer_metadata processors
by default. This network information metadata is used in observability solutions.

Co-authored-by: Dan Roscigno <dan@roscigno.com>
(cherry picked from commit 4ea0f91)
@jsoriano jsoriano mentioned this pull request Feb 18, 2020
Merged
5 tasks
@jsoriano jsoriano removed the needs_backport PR is waiting to be backported to other branches. label Feb 18, 2020
jsoriano added a commit that referenced this pull request Feb 19, 2020
@jsoriano @DanRoscigno
Enable netinfo in add metadata processors (#16077) (#16398)
a6dd4c4 
Enable netinfo in add_host_metadata and add_observer_metadata processors
by default. This network information metadata is used in observability solutions.

(cherry picked from commit 4ea0f91)

Co-authored-by: Dan Roscigno <dan@roscigno.com>
kvch pushed a commit to kvch/beats that referenced this pull request Feb 20, 2020
@jsoriano @DanRoscigno @kvch
Enable netinfo in add metadata processors (elastic#16077)
2d0de5d 
Enable netinfo in add_host_metadata and add_observer_metadata processors
by default. This network information metadata is used in observability solutions.

Co-authored-by: Dan Roscigno <dan@roscigno.com>
@andrewkroh andrewkroh mentioned this pull request Feb 21, 2020
Closed
@andrewvc andrewvc mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@DanRoscigno DanRoscigno Awaiting requested review from DanRoscigno

@exekias exekias Awaiting requested review from exekias

Assignees

@jsoriano jsoriano

Labels
enhancement libbeat review Team:Platforms Label for the Integrations - Platforms team v7.7.0 [zube]: Done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsoriano @andrewkroh @kaiyan-sheng @andresrc