-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add region to googlecloud module config #16203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
in progress
Pull request is currently in progress.
needs_backport
PR is waiting to be backported to other branches.
Team:Platforms
Label for the Integrations - Platforms team
labels
Feb 8, 2020
exekias
reviewed
Feb 11, 2020
kaiyan-sheng
added
review
and removed
[zube]: In Progress
in progress
Pull request is currently in progress.
labels
Feb 12, 2020
I will revisit this PR after #15598 get merged. |
sayden
approved these changes
Feb 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good! I'm impressed 😃
5 tasks
kaiyan-sheng
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review
Team:Platforms
Label for the Integrations - Platforms team
test-plan
Add this PR to be manual test plan
test-plan-added
This PR has been added to the test plan
v7.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to add region as a config parameter in googlecloud module. If region is specified, instances in all zones under that region will be collected.
Why is it important?
This way, if users need to collect metrics from us-west-1a, us-west-1b and us-west-1c, they don't need to specify one section of config for each zone in googlecloud.yml. For example:
Instead, with this PR, only
region: us-west-1
is needed in the config:Checklist
How to test this PR locally
Use config below, googlecloud metricset should collect compute metrics from all instances under us-central1 region, which includes us-central1-a, us-central1-b, us-central1-c, and us-central1-f.
Related issues