Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk used visualization in system host overview dashboard #16275

Merged
merged 3 commits into from
Feb 24, 2020

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Feb 12, 2020

What does this PR do?

This change updates the Disk Used to honor default collecting period
for fsstat metricset (1m). Visualization sets the query to >=1m to
make sure we get a big enough bucket size when querying fsstat metrics.

image

Why is it important?

Without this change the host overview dashboard may or may not show the correct value for used disk.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Related issues

This change updates the `Disk Used` to honor default collecting period
for `fsstat` metricset (1m). Visualization sets the query to `>=1m` to
make sure we get a big enough bucket size when querying fsstat metrics.
@exekias exekias requested a review from a team as a code owner February 12, 2020 14:19
@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Feb 20, 2020
@exekias
Copy link
Contributor Author

exekias commented Feb 20, 2020

I included CHANGEME_HOSTNAME var (7972737) as tests were failing. When we test this we need to make sure that link between overall System overview and Host specific overview works. That means, when in the main System overview dashboard, clicking in one of the hosts in the histogram view leads to the host overview dashboard filtered to that host.

@exekias exekias added the test-plan Add this PR to be manual test plan label Feb 20, 2020
@exekias
Copy link
Contributor Author

exekias commented Feb 20, 2020

I had a chat with @narph, this is a good workaround for most cases (people using defaults), but we are keeping #12435 open to see if we can find a solution that is good for any configured period.

@exekias exekias merged commit b0c600a into elastic:master Feb 24, 2020
exekias pushed a commit to exekias/beats that referenced this pull request Feb 25, 2020
…c#16275)

* Fix disk used visualization in system host overview dashboard

This change updates the `Disk Used` to honor default collecting period
for `fsstat` metricset (1m). Visualization sets the query to `>=1m` to
make sure we get a big enough bucket size when querying fsstat metrics.

* Put `CHANGEME_HOSTNAME` back in the dashboard

(cherry picked from commit b0c600a)
@exekias exekias added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 25, 2020
exekias pushed a commit that referenced this pull request Feb 27, 2020
#16550)

* Fix disk used visualization in system host overview dashboard

This change updates the `Disk Used` to honor default collecting period
for `fsstat` metricset (1m). Visualization sets the query to `>=1m` to
make sure we get a big enough bucket size when querying fsstat metrics.

* Put `CHANGEME_HOSTNAME` back in the dashboard

(cherry picked from commit b0c600a)
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 21, 2020
@exekias
Copy link
Contributor Author

exekias commented Mar 26, 2020

In order to test this we need to deploy Metricbeat with the system module enabled (it is by default), then:

  • Go to the system overview dashboard, check that our host appears in the hosts list
  • Check that clicking on it goes to the host overview dashboard
  • Check that the disk usage graphs have data (before the change that was not always the case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug :Dashboards Metricbeat Metricbeat Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants