Fix loading processors from autodiscover hints #16348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if str, ok := value.(string); ok { | ||
| cfg := common.MapStr{} | ||
| if err := json.Unmarshal([]byte(str), &cfg); err != nil { | ||
| logp.Debug("autodiscover.builder", "unable to unmarshal json due to error: %v", err) |
There was a problem hiding this comment.
Does this need to be logp.Debugf?
There was a problem hiding this comment.
Checked the code, seems logp.Debug is correct. It accepts parameters for the format string.
kaiyan-sheng
approved these changes
Feb 18, 2020
blakerouse
added
the
needs_backport
4 tasks
blakerouse
added
v7.7.0
and removed
needs_backport
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Feb 18, 2020
* Parse processors from hints as JSON. * Add test. * Add changelog entry. (cherry picked from commit d1f383f)
blakerouse
added
containers
kvch
pushed a commit
to kvch/beats
that referenced
this pull request
Feb 20, 2020
* Parse processors from hints as JSON. * Add test. * Add changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where processors from autodiscover hints where not convered into a
common.MapStr.Why is it important?
Allows processors to be defined in autodiscover hints.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesAuthor's Checklist
stringtocommon.MapStrHow to test this PR locally
Run filebeat with:
Start container with processor:
docker run -l 'co.elastic.logs/processors.add_fields={"fields":{"foo":"bar"}}' busybox echo helloCheck that filebeat was able to start logging it the container with the fields added.
Related issues
Use cases
Screenshots
Logs