Filebeat Okta module #16362
Merged
Filebeat Okta module #16362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 13, 2020 15:50
|
Pinging @elastic/siem (Team:SIEM) |
leehinman
requested changes
Feb 24, 2020
There was a problem hiding this comment.
Looks really good.
A couple of suggestions for mappings
- add client.ip & source.ip to related.ip array
- set event.kind to event
- set event.category (are both iam and authentication appropriate?)
- set event.type (allowed/denied for logins, probably user as well?)
- map okta.event_type to event.action
- map okta.outcome.result to event.outcome
- map okta.uuid -> event.id
- map okta.actor.display_name to user.full_name if okta.actor.type is User
- map okta.actor.id to user.id if okta.actor.type is User
andrewkroh
requested changes
Feb 25, 2020
andrewkroh
reviewed
Feb 25, 2020
|
Please add an overview dashboard to accompany the module and highlight some of the key signals coming from the data (activity over time, geo data, failures, etc). |
andrewkroh
reviewed
Mar 12, 2020
andrewkroh
reviewed
Mar 13, 2020
There was a problem hiding this comment.
There were some more renames of OKTA to Okta.
@alakahakai Is this ready for another look by @leehinman?
I think the only thing left is to add an overview dashboard. Maybe you want to add that in a follow up PR to get the testing going sooner?
leehinman
requested changes
Mar 16, 2020
x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
Outdated
Show resolved
Hide resolved
x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
Show resolved
Hide resolved
x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
Show resolved
Hide resolved
x-pack/filebeat/module/okta/system/test/okta-system-test.json.log-expected.json
Outdated
Show resolved
Hide resolved
leehinman
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filebeat Okta module for Okta system logs.