Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Fixing up compatibility statements for stack modules #16400

Merged
merged 5 commits into from
Feb 19, 2020

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

Updates the compatibility statements in Metricbeat stack modules, viz. elasticsearch, logstash, beat, and kibana.

Why is it important?

The compatibility statements were outdated.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works

@ycombinator ycombinator added docs Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Feb 18, 2020
@ycombinator ycombinator requested a review from a team as a code owner February 18, 2020 19:45
metricbeat/module/beat/docs.asciidoc Outdated Show resolved Hide resolved
@ycombinator
Copy link
Contributor Author

Simplified the version compatibility language. Ready for another review, @dedemorton. Thanks!

@ycombinator ycombinator added needs_backport PR is waiting to be backported to other branches. v7.6.1 v7.7.0 v8.0.0 labels Feb 18, 2020
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Contributor Author

Travis CI is green and Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit 239a447 into elastic:master Feb 19, 2020
@ycombinator ycombinator deleted the mb-stack-compat branch February 19, 2020 15:59
ycombinator added a commit to ycombinator/beats that referenced this pull request Feb 19, 2020
…astic#16400)

* [Metricbeat] Fixing up compatibility statements for stack modules

* Simplifying language

* Updating docs

* Moving Beats docs to correct location

* Updating Beat module docs
ycombinator added a commit to ycombinator/beats that referenced this pull request Feb 19, 2020
…astic#16400)

* [Metricbeat] Fixing up compatibility statements for stack modules

* Simplifying language

* Updating docs

* Moving Beats docs to correct location

* Updating Beat module docs
ycombinator added a commit that referenced this pull request Feb 19, 2020
…6400) (#16425)

* [Metricbeat] Fixing up compatibility statements for stack modules

* Simplifying language

* Updating docs

* Moving Beats docs to correct location

* Updating Beat module docs
kvch pushed a commit to kvch/beats that referenced this pull request Feb 20, 2020
…astic#16400)

* [Metricbeat] Fixing up compatibility statements for stack modules

* Simplifying language

* Updating docs

* Moving Beats docs to correct location

* Updating Beat module docs
ycombinator added a commit that referenced this pull request Feb 24, 2020
…6400) (#16426)

* [Metricbeat] Fixing up compatibility statements for stack modules

* Simplifying language

* Updating docs

* Moving Beats docs to correct location

* Updating Beat module docs
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants