Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #16514 to 7.x: Remove stateful processors from the script processor #16544

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Feb 25, 2020

Cherry-pick of PR #16514 to 7.x branch. Original message:

What does this PR do?

Remove stateful processors from the script processor.

This is a breaking change because it will make scripts fail if they use these
processors. But it is quite unlikely that these processors are used in scripts
in production deployments because they would produce memory and file
descriptor leaks.

Why is it important?

There are some processors that keep resources that would need to be
explicitly released when the processor is not needed anymore. At this
moment there is no way to do it, processors have a stateless interface,
so avoid using these processors in scripts.

If these processors are needed, it is usually better to place them in
global configuration.

Processors removed are the ones used to add docker and kubernetes
metadata.

Related issues

More context in #16349.

There are some processors that keep resources that would need to be
explicitly released when the processor is not needed anymore. At this
moment there is no way to do it, processors have a stateless interface,
so avoid using these processors in scripts.

If these processors are needed, it is usually better to place them in
global configuration.

Processors removed are the ones used to add docker and kubernetes
metadata.

(cherry picked from commit 8d31a51)
@jsoriano jsoriano self-assigned this Mar 4, 2020
@andresrc andresrc added [zube]: Inbox Team:Platforms Label for the Integrations - Platforms team labels Mar 10, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jsoriano jsoriano merged commit 741599c into elastic:7.x Mar 12, 2020
@jsoriano jsoriano deleted the backport_16514_7.x branch March 12, 2020 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport review Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants