-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Add a system/users metricset #16569
Merged
fearful-symmetry
merged 25 commits into
elastic:master
from
fearful-symmetry:users-metricset
Mar 6, 2020
Merged
[Metricbeat] Add a system/users metricset #16569
fearful-symmetry
merged 25 commits into
elastic:master
from
fearful-symmetry:users-metricset
Mar 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a1ddc9e.
fearful-symmetry
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Feb 25, 2020
jenkins, test this |
blakerouse
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Tested it out on Ubuntu 19.10, works as described.
jsoriano
reviewed
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are some small things we could fix before merging.
jsoriano
approved these changes
Mar 3, 2020
kvch
reviewed
Mar 4, 2020
kvch
reviewed
Mar 4, 2020
fearful-symmetry
force-pushed
the
users-metricset
branch
2 times, most recently
from
March 5, 2020 15:13
1453622
to
7df7184
Compare
jsoriano
approved these changes
Mar 5, 2020
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Mar 9, 2020
* fix file check bug, deal with logging * init commit of users metricset * vendor new sub-systemd dep * refactor dbus calling code * Revert "vendor new sub-systemd dep" This reverts commit a1ddc9e. * make fmt * cleanup, fix tests * fix cross-compile issues * update docs * code quality cleanup * make update * fix deps, update vendor * update notice * add changelog * fix changelog, add example config (cherry picked from commit a034a92)
2 tasks
fearful-symmetry
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 9, 2020
fearful-symmetry
added a commit
that referenced
this pull request
Mar 10, 2020
…16905) * [Metricbeat] Add a system/users metricset (#16569) * fix file check bug, deal with logging * init commit of users metricset * vendor new sub-systemd dep * refactor dbus calling code * Revert "vendor new sub-systemd dep" This reverts commit a1ddc9e. * make fmt * cleanup, fix tests * fix cross-compile issues * update docs * code quality cleanup * make update * fix deps, update vendor * update notice * add changelog * fix changelog, add example config (cherry picked from commit a034a92) * make update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR adds a new metricset, system/users, that uses
login1
and dbus to report on user sessions, complete with remote IPs, user IDs, and root PIDs.How do I test it?
TODO