Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for histogram type in fields.yml #16570

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Add support for histogram type in fields.yml #16570

merged 4 commits into from
Mar 5, 2020

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Feb 25, 2020

What does this PR do?

Add support for Elasticsearch Histogram type in fields.yml / mappings

Why is it important?

We plan to use histogram type in several efforts, including Prometheus module (#14843). It should help of making a better use of Elasticsearch when storing histograms, providing better performance on storage & querying times.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@exekias exekias added enhancement libbeat in progress Pull request is currently in progress. labels Feb 25, 2020
@exekias exekias marked this pull request as ready for review February 25, 2020 16:46
@exekias exekias requested a review from a team February 28, 2020 09:33
ChrsMark
ChrsMark approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise it is looking good. However not sure if there are any tricky parts that someone else more familiar with this area could catch.

@jsoriano
Copy link
Member

Error in travis should be solved by #16681

@exekias
Copy link
Contributor Author

exekias commented Feb 28, 2020

I will rebase on top once that one is merged, thank you for fixing it!

@exekias exekias merged commit 9710e3b into elastic:master Mar 5, 2020
exekias pushed a commit to exekias/beats that referenced this pull request Mar 5, 2020
Add support for histogram type in fields.yml (elastic#16570)
6ca67f3 
(cherry picked from commit 9710e3b)
@exekias exekias mentioned this pull request Mar 5, 2020
Merged
3 tasks
@exekias exekias added the v7.7.0 label Mar 5, 2020
exekias pushed a commit that referenced this pull request Mar 23, 2020
Cherry-pick #16570 to 7.x: Add support for histogram type in fields.y…
a5d8979 
…ml (#16835)

* Add support for histogram type in fields.yml (#16570)

(cherry picked from commit 9710e3b)

* Update CHANGELOG.next.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees
No one assigned
Labels
enhancement in progress Pull request is currently in progress. libbeat v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exekias @jsoriano @ChrsMark