Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16621 to 7.x: Add Cloud Foundry Processor #16666

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Cherry-pick #16621 to 7.x: Add Cloud Foundry Processor #16666

merged 2 commits into from
Feb 27, 2020

Conversation

blakerouse
Copy link
Contributor

Cherry-pick of PR #16621 to 7.x branch. Original message:

What does this PR do?

Adds a add_cloudfoundry_metadata processor that adds application metadata to an event with a Cloud Foundry application ID.

Why is it important?

To provide more context on the application for the event. Processor allows this to easily be shared between both metricbeat and filebeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

With a running cloud foundry us the following filebeat configuration:

filebeat.inputs:
  - &cloudfoundry
    type: cloudfoundry
    api_address: https://api.dev.cfdev.sh
    skip_verify: true
    client_id: firehose-to-filebeat
    client_secret: verysecret

processors:
  - add_cloudfoundry_metadata:
      <<: *cloudfoundry

output.console:
  pretty: true

Related issues

Use cases

Screenshots

Logs

@blakerouse
Add Cloud Foundry Processor (elastic#16621)
8261800 
* Add the cloudfoundry metadata processor.

* Fix testing and documentation.

* Add changelog entry.

* Run mage fmt.

* Fix docs.

* Update asciidoc to set role=xpack and experimental.

* Switch from cf to cloudfoundry for event key. Improve some event fields. Fix changelog, and update asciidoc to reference the field that is read for application ID.

* Update fields.yml from cf to cloudfoundry.

(cherry picked from commit 1e0c818)
@blakerouse blakerouse requested a review from a team February 27, 2020 16:25
@blakerouse
Copy link
Contributor Author

@kaiyan-sheng Thanks for the review, fixed the issues. Ready for another look.

@blakerouse blakerouse merged commit a621de1 into elastic:7.x Feb 27, 2020
@blakerouse blakerouse deleted the backport_16621_7.x branch February 27, 2020 21:39
@blakerouse blakerouse added the test-plan Add this PR to be manual test plan label Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees
No one assigned
Labels
backport review test-plan Add this PR to be manual test plan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blakerouse @kaiyan-sheng