Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center more functionality around RunnerFactory #16715

Merged
merged 14 commits into from
Mar 26, 2020
Merged

Center more functionality around RunnerFactory #16715

merged 14 commits into from
Mar 26, 2020

Commits on Mar 10, 2020

  1. Center more functionality around RunnerFactory 

    Remove CheckableRunnerFactory and require RunnerFactory to implement
CheckConfig. CheckableRunnerFactory more and more superseded
RunnerFactory. As we want more config validation support in the future
as well I combined the two into RunnerFactory

Remove autodiscover.Adapter. The adapter did inherit from
CheckableRunnerFactory, giving us some inheritance chain between
RunnerFactory, CheckableRunnerFactory, and Adapter for autodiscovery.
By removig the Adapter and CheckableRunnerFactory we have one common
type (RunnerFactory) to integrate with config file reloading, static
input/module setup, and autodiscovery.

Add selectors for autodiscovery event selection that are used as
additional parameters when creating a new Autodiscover instance. This
gives us some more composability, yet I wonder if we can even remove those,
as every instance of NewAutodiscover did look for events with a 'config'
field of type []*common.Config.
    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    626a4df View commit details
    Browse the repository at this point in the history

  2. add missing license header

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    4259281 View commit details
    Browse the repository at this point in the history

  3. fix build

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    d69ad6c View commit details
    Browse the repository at this point in the history

  4. remove EventSelector

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    d2d13af View commit details
    Browse the repository at this point in the history

  5. Add godoc to cfgfile/factories.go

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    639b367 View commit details
    Browse the repository at this point in the history

  6. wrap error to show where it comes from in reloader

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    90577b0 View commit details
    Browse the repository at this point in the history

  7. More crawler improvements: 

    - wrap errors to give some context which operation failed
- do not leak inputloader background process if configuration fails
    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ec8cbc6 View commit details
    Browse the repository at this point in the history

  8. filebeat beater wrap error

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    2ea301f View commit details
    Browse the repository at this point in the history

  9. RunnerFactory.Create uses beat.PipelineConnector only

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    33c182a View commit details
    Browse the repository at this point in the history

  10. add nilpipeline

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    71ee8ca View commit details
    Browse the repository at this point in the history

  11. Implement CheckConfig for filebeat inputs/fileset factories

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    daf9964 View commit details
    Browse the repository at this point in the history

  12. fix some tests

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    5987016 View commit details
    Browse the repository at this point in the history

  13. godoc

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    83a4471 View commit details
    Browse the repository at this point in the history

  14. fix eventselect

    urso committed Mar 10, 2020
    Configuration menu
    Copy the full SHA
    ba9f277 View commit details
    Browse the repository at this point in the history