Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #16691 to 7.x: [libbeat] rename queue.Eventer -> queue.ACKListener #16765

Merged
merged 2 commits into from
Mar 5, 2020
Merged

Cherry-pick #16691 to 7.x: [libbeat] rename queue.Eventer -> queue.ACKListener #16765

merged 2 commits into from
Mar 5, 2020

Conversation

faec
Copy link
Contributor

@faec faec commented Mar 3, 2020 •
edited by andresrc
Loading

Cherry-pick of PR #16691 to 7.x branch. Original message:

What does this PR do?

queue.Eventer is an interface definition for types that can receive OnACK(eventCount int) calls, and is implemented by types that need to listen for incoming event ACKs. This PR renames it queue.ACKListener to better convey its purpose.

This PR introduces no user-visible changes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@faec faec requested a review from urso March 3, 2020 16:53
@faec faec merged commit 9034211 into elastic:7.x Mar 5, 2020
@faec faec deleted the backport_16691_7.x branch March 5, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
backport cleanup libbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faec @urso