-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets #16892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
in progress
Pull request is currently in progress.
needs_backport
PR is waiting to be backported to other branches.
Team:Platforms
Label for the Integrations - Platforms team
labels
Mar 6, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
kaiyan-sheng
added
review
and removed
in progress
Pull request is currently in progress.
labels
Mar 18, 2020
mtojek
reviewed
Mar 19, 2020
...ck/metricbeat/module/aws/_meta/kibana/7/dashboard/Metricbeat-aws-trasitgateway-overview.json
Outdated
Show resolved
Hide resolved
...ck/metricbeat/module/aws/_meta/kibana/7/dashboard/Metricbeat-aws-trasitgateway-overview.json
Outdated
Show resolved
Hide resolved
...ck/metricbeat/module/aws/_meta/kibana/7/dashboard/Metricbeat-aws-trasitgateway-overview.json
Outdated
Show resolved
Hide resolved
...ck/metricbeat/module/aws/_meta/kibana/7/dashboard/Metricbeat-aws-trasitgateway-overview.json
Show resolved
Hide resolved
exekias
approved these changes
Mar 20, 2020
5 tasks
kaiyan-sheng
added
v7.7.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Mar 20, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
Mar 20, 2020
…, transitgateway and natgateway metricsets (#17149) * [Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets (#16892) * Separate vpc metricset to vpn, transitgateway and natgateway metricsets * add dashboard and screenshot (cherry picked from commit 7a7c2af) * add changelog
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
review
Team:Platforms
Label for the Integrations - Platforms team
test-plan
Add this PR to be manual test plan
test-plan-added
This PR has been added to the test plan
v7.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to separate vpc metricset into three smaller metricsets: vpn, transitgateway and natgateway metricsets. This PR will also add dashboards for each metricset.
Why is it important?
This will help with users who only wants to enable one or two out of all three metricsets.
Checklist
Screenshots
vpn dashboard:
nat gateway dashboard:
transit gateway dashboard:
How to test this PR locally
Make sure the AWS account you use for testing has metrics for VPN, NATgateway, transit gateway.
Enable aws module and then change aws.yml to:
You should see metrics collection per every minute and dashboards should start showing data points as well.