Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets #16892

Merged
merged 12 commits into from
Mar 20, 2020
Merged

[Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets #16892

merged 12 commits into from
Mar 20, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Mar 6, 2020

What does this PR do?

This PR is to separate vpc metricset into three smaller metricsets: vpn, transitgateway and natgateway metricsets. This PR will also add dashboards for each metricset.

Why is it important?

This will help with users who only wants to enable one or two out of all three metricsets.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Screenshots

vpn dashboard:
Screen Shot 2020-03-18 at 12 21 41 PM (2)

nat gateway dashboard:
Screen Shot 2020-03-17 at 3 29 25 PM (2)

transit gateway dashboard:
Screen Shot 2020-03-18 at 1 39 46 PM (2)

How to test this PR locally

Make sure the AWS account you use for testing has metrics for VPN, NATgateway, transit gateway.
Enable aws module and then change aws.yml to:

- module: aws
  period: 1m
  credential_profile_name: elastic-test
  metricsets:
    - vpn
    - natgateway
    - transitgateway

You should see metrics collection per every minute and dashboards should start showing data points as well.

@kaiyan-sheng kaiyan-sheng self-assigned this Mar 6, 2020
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. needs_backport PR is waiting to be backported to other branches. Team:Platforms Label for the Integrations - Platforms team labels Mar 6, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@kaiyan-sheng kaiyan-sheng added review and removed in progress Pull request is currently in progress. labels Mar 18, 2020
@kaiyan-sheng kaiyan-sheng added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 20, 2020
kaiyan-sheng added a commit that referenced this pull request Mar 20, 2020
…, transitgateway and natgateway metricsets (#17149)

* [Metricbeat] Separate vpc metricset to vpn, transitgateway and natgateway metricsets (#16892)

* Separate vpc metricset to vpn, transitgateway and natgateway metricsets
* add dashboard and screenshot 

(cherry picked from commit 7a7c2af)

* add changelog
@kaiyan-sheng kaiyan-sheng added the test-plan Add this PR to be manual test plan label Mar 23, 2020
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Platforms Label for the Integrations - Platforms team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants