Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] Fix data race in convert processor #17032

Merged
merged 1 commit into from
Mar 16, 2020
Merged

[libbeat] Fix data race in convert processor #17032

merged 1 commit into from
Mar 16, 2020

Commits on Mar 16, 2020

  1. Fix data race in convert processor 

    If the convert processor was used in the global context it could lead to data races because there was a
variable that was reused across executions. When processors are used in the global context they are
shared across individual publisher clients so you could end up with a data race.

The fix here was to replace the shared state with a local variable. In testing this didn't make much of
a difference in the number of allocations.
    @andrewkroh
    andrewkroh committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    470fcd7 View commit details
    Browse the repository at this point in the history