Cherry-pick #17028 to 7.x: Ensure pprof endpoint is listening on startup #17081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pprof HTTP endpoint was being initialized asynchronously. In tests we have found that sometimes after Metricbeat has started, it fails to connect to the pprof endpoint. This can happen if the server is not listening before the rest of the beat is initialized. This change ensures that the listener for this endpoint is started before continuing with the rest of the initialization. Some comments and error messages have been polished. (cherry picked from commit efdab6f)
kaiyan-sheng
approved these changes
Mar 18, 2020
|
jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17028 to 7.x branch. Original message:
pprof HTTP endpoint was being initialized asynchronously. In tests we
have found that sometimes after Metricbeat has started, it fails to
connect to the pprof endpoint. This can happen if the server is not
listening before the rest of the beat is initialized.
This change ensures that the listener for this endpoint is started
before continuing with the rest of the initialization. This should reduce
flakiness of tests that depend on these endpoint (
test_statstests).Some comments and error messages have been polished.