Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test tag with Oracle #17082

Closed
wants to merge 3 commits into from
Closed

Add test tag with Oracle #17082

wants to merge 3 commits into from

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Mar 18, 2020

Adds the TEST_TAGS environment variable to Jenkins CI set to aws,azure,oracle

Continues / Related to: #16937
Related to: #17075

Pinging @jsoriano and @kuisathaverat

@sayden sayden added ci Team:Services (Deprecated) Label for the former Integrations-Services team labels Mar 18, 2020
@sayden sayden self-assigned this Mar 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

jsoriano
jsoriano reviewed Mar 18, 2020
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
@sayden sayden marked this pull request as ready for review March 18, 2020 19:56
kuisathaverat
kuisathaverat requested changes Mar 19, 2020
View reviewed changes
Jenkinsfile Outdated Show resolved Hide resolved
jsoriano
jsoriano reviewed Mar 19, 2020
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would you like to move this change to #16833 so both things are tested and merged together?

@kaiyan-sheng
Copy link
Contributor

Could you change the PR title please to remove aws and azure 😬

@sayden sayden changed the title Add test tag with aws, azure and oracle Add test tag with aws Mar 19, 2020
@sayden sayden changed the title Add test tag with aws Add test tag with Oracle Mar 19, 2020
@sayden
Copy link
Contributor Author

sayden commented Mar 19, 2020

LGTM, but would you like to move this change to #16833 so both things are tested and merged together?

Ok, let's close this and see everything working together

@sayden sayden closed this Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyan-sheng kaiyan-sheng kaiyan-sheng left review comments

@jsoriano jsoriano jsoriano left review comments

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Assignees

@sayden sayden

Labels
ci Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sayden @elasticmachine @kaiyan-sheng @jsoriano @kuisathaverat