Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source field in k8s events #17209

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Conversation

ChrsMark
Copy link
Member

What does this PR do?

This PR adds kubernetes.event.source.host and kubernetes.event.source.component leveraging the respective data of k8s API: https://godoc.org/k8s.io/api/core/v1#EventSource.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Related issues

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added enhancement containers Related to containers use case Team:Platforms Label for the Integrations - Platforms team labels Mar 24, 2020
@ChrsMark ChrsMark requested review from a team March 24, 2020 16:10
@ChrsMark ChrsMark self-assigned this Mar 24, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog and anyway a unit test could be added?

@ChrsMark
Copy link
Member Author

Missing changelog and anyway a unit test could be added?

👍 will add soonish!

@vsxen
Copy link

vsxen commented Mar 25, 2020

and add the fileld in this file ?
https://github.com/elastic/beats/blob/master/metricbeat/module/kubernetes/event/_meta/fields.yml

- name: source
  type: group
  description: >
    the event source 
....

@ChrsMark ChrsMark added [zube]: In Progress in progress Pull request is currently in progress. labels Mar 25, 2020
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added [zube]: In Review review and removed [zube]: In Progress in progress Pull request is currently in progress. labels Mar 26, 2020
@ChrsMark
Copy link
Member Author

@blakerouse could you have another look?

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChrsMark ChrsMark added needs_backport PR is waiting to be backported to other branches. v7.8.0 labels Mar 30, 2020
@ChrsMark ChrsMark merged commit f4b2826 into elastic:master Mar 30, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Mar 30, 2020
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Mar 30, 2020
ChrsMark added a commit that referenced this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case enhancement review Team:Platforms Label for the Integrations - Platforms team v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metricsbeat collect source field for k8s event
5 participants