-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add source field in k8s events #17209
Conversation
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing changelog and anyway a unit test could be added?
👍 will add soonish! |
and add the fileld in this file ? - name: source
type: group
description: >
the event source
.... |
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@blakerouse could you have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
(cherry picked from commit f4b2826)
What does this PR do?
This PR adds
kubernetes.event.source.host
andkubernetes.event.source.component
leveraging the respective data of k8s API: https://godoc.org/k8s.io/api/core/v1#EventSource.Checklist
Related issues