Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Use Pod.Status.Phase for pod updates in kubernetes autodiscovery #17223

Merged
merged 2 commits into from
Mar 25, 2020
Merged

[BUG] Use Pod.Status.Phase for pod updates in kubernetes autodiscovery #17223

merged 2 commits into from
Mar 25, 2020

Commits on Mar 24, 2020

  1. Use Pod.Status.Phase for pod updates in kubernetes autodiscovery 

    This change fixes several issues with filebeat loosing events when
using kubernetes autodiscovery by incorrectly handling of pod states.

Switch the pod status verification in OnUpdate() from
ObjectMeta.DeletionTimestamp (which is present only for deleted pods)
to Pod.Status.Phase in order to correctly handle pod states.

ObjectMeta.DeletionTimestamp is only present for deleted pods and when a
pod runs to completion (eg. pods generated by conjobs), OnUpdate()
will emit a pod stop event disrespecting the CleanupTimeout leading to
early termination of running beats.
    @brunotm
    brunotm committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    0c43a8e View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. add issue PR reference to changelog

    @brunotm
    brunotm committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    5108a0c View commit details
    Browse the repository at this point in the history