Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Disk Used and Disk Usage visualizations in the Metricbeat System dashboard #17272

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

narph
Copy link
Contributor

@narph narph commented Mar 26, 2020

What does this PR do?

Rewrites the Metricbeat System Overview and Metricbeat Host Overview dashboards, only updates the Disk Usage and Disk used visualizations.

Why is it important?

Fixes #12435
Detailed explanation here #12435 (comment)
The TSVB will in all visualizations except the time series will only show the value of the last data and not the data of the selected time range. So, if no documents are found in the last bucket, value will be 0. Increasing the bucket interval in order to include at least one meaningful doc will fix the issue.
The 2 visualizations are populated by data from the fsstat metricset which by default has a higher interval, so the visualizations were rarely showing any results.

The visualizations reflect the last value and will search over all the documents selected in the timepicker.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@narph narph self-assigned this Mar 26, 2020
@narph narph added [zube]: In Review Metricbeat Metricbeat Team:Integrations Label for the Integrations team labels Mar 26, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@narph narph requested a review from exekias March 26, 2020 19:26
@exekias exekias added the needs_backport PR is waiting to be backported to other branches. label Mar 27, 2020
@narph narph merged commit ac7aa9d into elastic:master Mar 27, 2020
@narph narph deleted the fix-win-dash branch March 27, 2020 12:27
narph added a commit to narph/beats that referenced this pull request Mar 27, 2020
…dashboard (elastic#17272)

* fix

* changelog

(cherry picked from commit ac7aa9d)
@narph narph added the v7.7.0 label Mar 27, 2020
narph added a commit to narph/beats that referenced this pull request Mar 27, 2020
…dashboard (elastic#17272)

* fix

* changelog

(cherry picked from commit ac7aa9d)
narph added a commit that referenced this pull request Mar 27, 2020
…dashboard (#17272) (#17285)

* fix

* changelog

(cherry picked from commit ac7aa9d)
narph added a commit that referenced this pull request Mar 30, 2020
…dashboard (#17272) (#17286)

* fix

* changelog

(cherry picked from commit ac7aa9d)
@narph narph added test-plan Add this PR to be manual test plan and removed needs_backport PR is waiting to be backported to other branches. labels Mar 31, 2020
@andresrc andresrc added the test-plan-added This PR has been added to the test plan label Apr 1, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Metricbeat Metricbeat Team:Integrations Label for the Integrations team test-plan Add this PR to be manual test plan test-plan-added This PR has been added to the test plan v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disk Usage visualization always 0
4 participants