-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process.command_line to Sysmon module #17327
Conversation
Adds the process.command_line field to Sysmon module that does not split the field into multiple values.
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
💚 CLA has been signed |
Pinging @elastic/siem (Team:SIEM) |
I did sign CLA, looks like the bot hasn't updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
@@ -307,6 +307,7 @@ var sysmon = (function () { | |||
return; | |||
} | |||
evt.Put(field, winlogbeat.splitCommandLine(commandLine)); | |||
evt.Put("process.command_line", commandLine); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out where this function is called. It's used in two different contexts so hard-coding the target field won't work. I suggest changing the field
parameter to be the target namespace. Like this, then update the callers.
var splitCommandLine = function(evt, namespace) {
var commandLine = evt.Get(field);
if (!commandLine) {
return;
}
evt.Put(namespace+".args", winlogbeat.splitCommandLine(commandLine));
evt.Put(namespace+".command_line", commandLine);
}
I opened #17823 to finish the change. It looks like this fork no longer exists. |
Adds the process.command_line field to Sysmon module that does not split the field into multiple values.
-Enhancement
What does this PR do?
Added process.command_line field to sysmon module.
Why is it important?
Previously the only field for the Sysmon module was
process.args
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues