[7.6] Allow a wider range of characters for logstash.log.pipeline_id (#17243) #17339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
[zube]: In Review
backport
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
blakerouse
approved these changes
Mar 30, 2020
CHANGELOG.next.asciidoc
Outdated
| @@ -49,6 +49,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Add queue_url definition in manifest file for aws module. {pull}16640{16640} | |||
| - Fixed a mapping exception when ingesting CEF logs that used the spriv or dpriv extensions. {issue}17216[17216] {pull}17220[17220] | |||
| - Fix `elasticsearch.gc` fileset to not collect _all_ logs when Elasticsearch is running in Docker. {issue}13164[13164] {issue}16583[16583] {pull}17164[17164] | |||
| - CEF: Fixed decoding errors caused by trailing spaces in messages. {pull}17253[17253] | |||
There was a problem hiding this comment.
Same as the 7.x backport, +1 with this fixed.
|
Failing CI tests are related. Will investigate and fix! |
|
Thanks @ycombinator . Can you also backport to 7.7 branch? |
* Allow a wider range of characters for logstash.log.pipeline_id Allow a wider range of characters for `logstash.log.pipeline_id`. The `NOTSPACE` should be fine, but for covering any case, `DATA` would be safer. Should solve #17242 * update tests for logstash plain 7.4 pipeline id * Failed tests * update changelog
ycombinator
force-pushed
the
backport/7.6/pr-17243
branch
from
b6bfee8
to
a77bb44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.6: