-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat]Combine metrics with no dimension into one event #17345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
bug
needs_backport
PR is waiting to be backported to other branches.
Team:Platforms
Label for the Integrations - Platforms team
labels
Mar 30, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
ChrsMark
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Wondering if we could have a unit test to ensure this functionality.
@ChrsMark Totally agree on adding more unit test. I just added two tests for CreateEvents function. Thank you! |
ChrsMark
approved these changes
Apr 1, 2020
Merged
6 tasks
kaiyan-sheng
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Apr 1, 2020
Merged
6 tasks
kaiyan-sheng
added a commit
that referenced
this pull request
Apr 2, 2020
kaiyan-sheng
added a commit
that referenced
this pull request
Apr 2, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#17345) (elastic#17403) * Combine metrics with no dimension * Add unit tests for CreateEvents function w/o dimensions (cherry picked from commit 1866bfc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When collecting CloudWatch metrics with no dimension, they should be reported in the same metric/event instead of separate metrics/events. For example, lambda namespace reports metrics across all functions: ConcurrentExecutions, Duration, Errors, Invocations, Throttles. For metrics across all functions, they represent aggregate metrics for all functions in the current AWS Region. Instead of separating these metrics into individual events, cloudwatch metricset should report them as one metric.
Why is it important?
Combining metrics with no dimension into one event will easily show users all the aggregated metrics from CloudWatch in one event.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
./metricbeat modules enable aws