Add regex based cid extractor to add_process_metadata #17360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Here is optional regex based container id extractor functionality added to add_process_metadata. Regards, |
|
@exekias auto checks green and checklist check-boxes checked now :) |
exekias
added
enhancement
review
Team:Platforms
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
exekias
approved these changes
Apr 2, 2020
|
ok to test |
exekias
added
the
needs_backport
|
Thank you so much for contributing! Waiting for a green light from the CI |
5 tasks
exekias
pushed a commit
to exekias/beats
that referenced
this pull request
Apr 3, 2020
* Add regex based cid extractor to add_process_metadata Co-authored-by: Jako Tinkus <jatinkus@microsoft.com> (cherry picked from commit b92c6c3)
exekias
added
v7.8.0
and removed
needs_backport
exekias
pushed a commit
that referenced
this pull request
May 8, 2020
This was referenced Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds regex based cid extractor to add_kubernetes_metadata
Why is it important?
Adds more flexibility and makes possible to bypass bug with kube-proxy cid turning out to be "kube-proxy"
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Relates:
#15947
#17351
Use cases
Screenshots
Logs