Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction to googlecloud/firewall docs #17365

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 31, 2020

What does this PR do?

Fixes misleading config example in the docs for Filebeat's googlecloud/firewall fileset.

Why is it important?

Well it's not that important.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr merged commit 57156fc into elastic:master Apr 1, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Apr 1, 2020
@adriansr adriansr added the v7.8.0 label Apr 1, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Apr 1, 2020
@adriansr adriansr added the v7.7.0 label Apr 1, 2020
adriansr added a commit that referenced this pull request Apr 2, 2020
adriansr added a commit that referenced this pull request Apr 2, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants