Fix mbean parsing for mbeans with multiple quoted properties #17374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
bug
in progress
|
Pinging @elastic/integrations (Team:Integrations) |
jsoriano
force-pushed
the
fix-mbeans-multiple-quoted-properties
branch
from
926e4d1
to
8599859
Compare
jsoriano
added
[zube]: In Review
needs_backport
…-quoted-properties
Merged
7 tasks
jsoriano
removed
the
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 1, 2020
…#17374) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 7b6d7c4)
Merged
7 tasks
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 1, 2020
…#17374) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 7b6d7c4)
Merged
7 tasks
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Apr 1, 2020
…#17374) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 7b6d7c4)
jsoriano
added a commit
that referenced
this pull request
Apr 7, 2020
…#17405) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 7b6d7c4)
jsoriano
added a commit
that referenced
this pull request
Apr 7, 2020
…#17407) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 7b6d7c4)
jsoriano
added a commit
that referenced
this pull request
Apr 7, 2020
…#17408) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 7b6d7c4)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…#17374) (elastic#17407) There are mbeans that can contain multiple quoted properties, and Metricbeat was failing to correctly parse them. Fix the regular expression used for parsing to cover this case. Also small refactors in tests and to remove an almost duplicated regular expression. (cherry picked from commit 46f74f6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix mbean parsing when multiple properties are quoted.
Why is it important?
There are mbeans that can contain multiple quoted properties, and we are failing to correctly parse them.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
Related issues