-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboards for Google Cloud Audit and AWS CloudTrail #17379
Add dashboards for Google Cloud Audit and AWS CloudTrail #17379
Conversation
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you also add the screenshots into https://github.com/elastic/beats/tree/master/filebeat/docs/images please? Some mage commands will probably be needed after that to update the docs.
9dfce20
to
aa8366d
Compare
Add dashboards for Google Cloud Audit and AWS Cloud Trail.
googlecloud/audit was missing docs so I added them.
aa8366d
to
3864e44
Compare
@kaiyan-sheng Good idea. Those screen shots are now added to the documentation for the respective modules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Add dashboards for Google Cloud Audit and AWS Cloud Trail. Add images to docs googlecloud/audit was missing docs so I added them. (cherry picked from commit a7ada06)
What does this PR do?
Add dashboards for Google Cloud Audit and AWS Cloud Trail.
Screenshots
AWS CloudTrail
Google Cloud Audit