Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboards for Google Cloud Audit and AWS CloudTrail #17379

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

andrewkroh
Copy link
Member

What does this PR do?

Add dashboards for Google Cloud Audit and AWS Cloud Trail.

Screenshots

AWS CloudTrail
Firefox_Screenshot_2020-03-31T22-40-02 320Z

Google Cloud Audit
Firefox_Screenshot_2020-03-31T23-21-16 561Z

@andrewkroh andrewkroh added enhancement review Filebeat Filebeat :Dashboards needs_backport PR is waiting to be backported to other branches. Team:SIEM labels Apr 1, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you also add the screenshots into https://github.com/elastic/beats/tree/master/filebeat/docs/images please? Some mage commands will probably be needed after that to update the docs.

@andrewkroh andrewkroh force-pushed the feature/fb/aws-gcp-dashboards branch from 9dfce20 to aa8366d Compare April 6, 2020 00:45
Add dashboards for Google Cloud Audit and AWS Cloud Trail.
googlecloud/audit was missing docs so I added them.
@andrewkroh andrewkroh force-pushed the feature/fb/aws-gcp-dashboards branch from aa8366d to 3864e44 Compare April 6, 2020 00:46
@andrewkroh
Copy link
Member Author

@kaiyan-sheng Good idea. Those screen shots are now added to the documentation for the respective modules.

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andrewkroh andrewkroh merged commit a7ada06 into elastic:master Apr 6, 2020
andrewkroh added a commit to andrewkroh/beats that referenced this pull request May 6, 2020
Add dashboards for Google Cloud Audit and AWS Cloud Trail.

Add images to docs

googlecloud/audit was missing docs so I added them.

(cherry picked from commit a7ada06)
@andrewkroh andrewkroh added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels May 6, 2020
andrewkroh added a commit that referenced this pull request May 6, 2020
…8276)

Add dashboards for Google Cloud Audit and AWS Cloud Trail.

Add images to docs

googlecloud/audit was missing docs so I added them.

(cherry picked from commit a7ada06)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants