Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with output reloading #17381

Merged
merged 34 commits into from
Apr 21, 2020
Merged

Fix issues with output reloading #17381

merged 34 commits into from
Apr 21, 2020

Commits on Apr 20, 2020

  1. Refactoring: extracting common fields into worker struct

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    ccefba0 View commit details
    Browse the repository at this point in the history

  2. More refactoring

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    7e5e57c View commit details
    Browse the repository at this point in the history

  3. Address goroutine leak in publisher

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    89aa8cb View commit details
    Browse the repository at this point in the history

  4. Workaround: add Connection: close header to prevent FD leaks

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    03db189 View commit details
    Browse the repository at this point in the history

  5. Adding CHANGELOG entry

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    6d160f4 View commit details
    Browse the repository at this point in the history

  6. Adding IdleConnTimeout setting

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    c8a16c6 View commit details
    Browse the repository at this point in the history

  7. Close idle connections when ES client is closed

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    f28d0b7 View commit details
    Browse the repository at this point in the history

  8. When closing worker, make sure to cancel in-flight batches

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    d9bc4e5 View commit details
    Browse the repository at this point in the history

  9. Cancel batch + guard

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    5d3b10e View commit details
    Browse the repository at this point in the history

  10. [WIP] Adding output reload test

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    5c4daff View commit details
    Browse the repository at this point in the history

  11. More WIP

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    71b1d55 View commit details
    Browse the repository at this point in the history

  12. Update test

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    9ce4b54 View commit details
    Browse the repository at this point in the history

  13. Try to get test passing for client first

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    014fd25 View commit details
    Browse the repository at this point in the history

  14. Make workqueue shared

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    5c5e48a View commit details
    Browse the repository at this point in the history

  15. Making tests pass

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    6227a1f View commit details
    Browse the repository at this point in the history

  16. Clean up

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    ffd0822 View commit details
    Browse the repository at this point in the history

  17. Moving SeedFlag var to correct place

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    b97becc View commit details
    Browse the repository at this point in the history

  18. Clarifying comments

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    3aeebda View commit details
    Browse the repository at this point in the history

  19. Reducing the number of quick iterations

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    1208332 View commit details
    Browse the repository at this point in the history

  20. Reducing quick iterations even more

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    2039344 View commit details
    Browse the repository at this point in the history

  21. Trying just 1 iteration

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    8a03547 View commit details
    Browse the repository at this point in the history

  22. Setting out to nil after sending batch if paused

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    e31e53a View commit details
    Browse the repository at this point in the history

  23. Restoring old order of operations in Set()

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    dbf275a View commit details
    Browse the repository at this point in the history

  24. proposal

    @ycombinator
    urso authored and ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    a36cbb1 View commit details
    Browse the repository at this point in the history

  25. Do not copy mutex

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    229623f View commit details
    Browse the repository at this point in the history

  26. Remove debugging statements

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    f09c5e0 View commit details
    Browse the repository at this point in the history

  27. Bumping up testing/quick max count on TestOutputReload

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    896505c View commit details
    Browse the repository at this point in the history

  28. Removing commented out helper function

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    a59a56e View commit details
    Browse the repository at this point in the history

  29. Simplifying retryer now that workqueue is used across output loads

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    041922b View commit details
    Browse the repository at this point in the history

  30. Renaming parameter

    @ycombinator
    ycombinator committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    5ff7219 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Removing debugging variable

    @ycombinator
    ycombinator committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    15a1383 View commit details
    Browse the repository at this point in the history

  2. Reducing lower bound of random # of batches

    @ycombinator
    ycombinator committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6e10331 View commit details
    Browse the repository at this point in the history

  3. Removing sigUnWait from controller

    @ycombinator
    ycombinator committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    6a6680c View commit details
    Browse the repository at this point in the history

  4. Removing unused field

    @ycombinator
    ycombinator committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    09ccd8d View commit details
    Browse the repository at this point in the history