Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Memory leak and syscall fix #17500

Merged
merged 6 commits into from
Apr 6, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Apr 4, 2020

What does this PR do?

This fixes some syscall issues and a memory leak in auditbeat's socket module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

#16879 can rebase off of these fixes once they go in so we can backport this without introducing the refactor

Andrew Stucki and others added 3 commits April 4, 2020 15:27
@andrewstucki andrewstucki added bug review needs_backport PR is waiting to be backported to other branches. Auditbeat Team:SIEM labels Apr 4, 2020
@andrewstucki andrewstucki requested a review from a team as a code owner April 4, 2020 19:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing

@andrewstucki andrewstucki merged commit ff68af6 into elastic:master Apr 6, 2020
@andrewstucki andrewstucki deleted the socket_timeouts_fix branch April 6, 2020 12:06
@andrewstucki andrewstucki added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 6, 2020
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Apr 6, 2020
* Add code for reaping sockets after a set timeout

* Fix broken fileset under 32-bit OS.

This unrelated bug was introduced by elastic#15890 (unreleased).

* Add docs

* Update changelog

* Fix ordering issue

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit ff68af6)
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request Apr 6, 2020
* Add code for reaping sockets after a set timeout

* Fix broken fileset under 32-bit OS.

This unrelated bug was introduced by elastic#15890 (unreleased).

* Add docs

* Update changelog

* Fix ordering issue

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit ff68af6)
andrewstucki pushed a commit that referenced this pull request Apr 6, 2020
…17513)

* [Auditbeat] Memory leak and syscall fix (#17500)

* Add code for reaping sockets after a set timeout

* Fix broken fileset under 32-bit OS.

This unrelated bug was introduced by #15890 (unreleased).

* Add docs

* Update changelog

* Fix ordering issue

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit ff68af6)

* fix changelog
andrewstucki pushed a commit that referenced this pull request Apr 7, 2020
…17514)

* [Auditbeat] Memory leak and syscall fix (#17500)

* Add code for reaping sockets after a set timeout

* Fix broken fileset under 32-bit OS.

This unrelated bug was introduced by #15890 (unreleased).

* Add docs

* Update changelog

* Fix ordering issue

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit ff68af6)

* fix changelog
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
… fix (elastic#17514)

* [Auditbeat] Memory leak and syscall fix (elastic#17500)

* Add code for reaping sockets after a set timeout

* Fix broken fileset under 32-bit OS.

This unrelated bug was introduced by elastic#15890 (unreleased).

* Add docs

* Update changelog

* Fix ordering issue

Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
(cherry picked from commit a92b736)

* fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Auditbeat] Memory leak in 7.5.2
3 participants