Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libbeat] Clarify field name / remove redundant semaphore creation #17622

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

faec
Copy link
Contributor

@faec faec commented Apr 8, 2020

What does this PR do?

Rename queue.BufferConfig.Events to queue.BufferConfig.MaxEvents to clarify its meaning, and remove a redundant check of it in pipeline.go that created the semaphore Pipeline.eventSema twice.

This PR has no user-visible effects.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@faec faec merged commit bf3eb4c into elastic:master Apr 9, 2020
@faec faec added the v7.8.0 label Apr 9, 2020
faec added a commit to faec/beats that referenced this pull request Apr 9, 2020
faec added a commit that referenced this pull request Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants