-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] allow empty region/zone config param for storage metricset #17624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiyan-sheng
added
bug
Metricbeat
Metricbeat
needs_backport
PR is waiting to be backported to other branches.
Team:Platforms
Label for the Integrations - Platforms team
labels
Apr 8, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
blakerouse
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
6 tasks
kaiyan-sheng
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Apr 9, 2020
6 tasks
syepes
pushed a commit
to syepes/beats
that referenced
this pull request
Apr 9, 2020
…et (elastic#17624) * allow empty region/zone config param for storage metricset
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…et (elastic#17624) (elastic#17643) * allow empty region/zone config param for storage metricset (cherry picked from commit a8ef199)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is to allow storage metricset with no region/zone config parameter because based on the documentation:
If no region is specified, it will return metrics from all buckets.
https://github.com/elastic/beats/blob/master/x-pack/metricbeat/module/googlecloud/storage/_meta/docs.asciidoc
Why is it important?
GCP storage has two different classes, regional and multi-regional. When user wants to get storage metrics using Metricbeat for regional storage resources, a region/zone name can be specified in config. But if a region/zone is specified, no metrics can be queried from multi-regional storage resources.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues
Closes #17623
Screenshots
Here is a screenshot for showing metrics collected from all regions with config: