-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle ECS-compatible deprecation logs emitted by ES 8.0.0+ #17728
Merged
ycombinator
merged 4 commits into
elastic:master
from
ycombinator:fb-es-deprecation-800-ecs
Apr 17, 2020
Merged
Handle ECS-compatible deprecation logs emitted by ES 8.0.0+ #17728
ycombinator
merged 4 commits into
elastic:master
from
ycombinator:fb-es-deprecation-800-ecs
Apr 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ycombinator
added
[zube]: In Review
needs_backport
PR is waiting to be backported to other branches.
Feature:Stack Monitoring
Team:Services
(Deprecated) Label for the former Integrations-Services team
v7.8.0
v8.0.0
and removed
in progress
Pull request is currently in progress.
labels
Apr 16, 2020
Pinging @elastic/stack-monitoring (Stack monitoring) |
Pinging @elastic/integrations-services (Team:Services) |
ycombinator
force-pushed
the
fb-es-deprecation-800-ecs
branch
from
April 16, 2020 15:11
e991c03
to
3c37cb1
Compare
leehinman
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ycombinator
force-pushed
the
fb-es-deprecation-800-ecs
branch
from
April 16, 2020 22:06
3c37cb1
to
2a58251
Compare
Travis CI is green and Jenkins CI failures are unrelated. Merging. |
ycombinator
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Stack Monitoring
Team:Services
(Deprecated) Label for the former Integrations-Services team
v7.8.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With elastic/elasticsearch#47105 merged, starting with 8.0.0, Elasticsearch will emit ECS-compatible deprecation (and other types of) logs. This PR enhances the
elasticsearch/deprecation
fileset's ingestion pipeline to handle this new deprecation log format, while also remaining backwards-compatible with the previous (7.x) deprecation log format.Why is it important?
So the Filebeat
elasticsearch/deprecation
fileset can handle current as well as upcoming Elasticsearch deprecation log formats.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues