-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where application ID of cloudfoundry.access events is incorrect. #17847
Merged
blakerouse
merged 3 commits into
elastic:master
from
blakerouse:fix-cloudfoundry-access-uuid
Apr 21, 2020
Merged
Fix issue where application ID of cloudfoundry.access events is incorrect. #17847
blakerouse
merged 3 commits into
elastic:master
from
blakerouse:fix-cloudfoundry-access-uuid
Apr 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/integrations-platforms (Team:Platforms) |
blakerouse
force-pushed
the
fix-cloudfoundry-access-uuid
branch
from
April 20, 2020 20:44
cd5ad50
to
a511f47
Compare
exekias
reviewed
Apr 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! could you add some unit tests?
@exekias I have added unit tests to cover all the event types. |
exekias
approved these changes
Apr 21, 2020
exekias
added
the
needs_backport
PR is waiting to be backported to other branches.
label
Apr 21, 2020
mahak
pushed a commit
to mahak/beats
that referenced
this pull request
Apr 21, 2020
…rect. (elastic#17847) * Fix issue where application ID of cloudfoundry.access events is incorrect. * Add changelog entry. * Add unit tests for cloudfoundry events.
3 tasks
blakerouse
added
v7.8.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Apr 21, 2020
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Apr 21, 2020
…rect. (elastic#17847) * Fix issue where application ID of cloudfoundry.access events is incorrect. * Add changelog entry. * Add unit tests for cloudfoundry events. (cherry picked from commit 08e1b2b)
3 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Apr 21, 2020
…rect. (elastic#17847) * Fix issue where application ID of cloudfoundry.access events is incorrect. * Add changelog entry. * Add unit tests for cloudfoundry events. (cherry picked from commit 08e1b2b)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…rect. (elastic#17847) (elastic#17878) * Fix issue where application ID of cloudfoundry.access events is incorrect. * Add changelog entry. * Add unit tests for cloudfoundry events. (cherry picked from commit 66343d9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue where the cloudfoundry event for
cloudfoundry.access
event types was creating thecloudfoundry.app.id
in the memory format of the UUID instead of the required string formatted.Wrong:
low:3046190763798940950 high:12644936126740546741
Correct:
4ef05e5d-d2a6-4c58-9229-d112587b74dd
Why is it important?
The format must use the correct string so the
add_cloudfoundry_metadata
processor can get the application data from CloudFoundry. This is also causing stress on the cloudfoundry API as it will keep checking for applications that are invalid and cause 404's.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.