Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Update MSSQL module to use latest library version and fix release tags #17862

Merged
merged 8 commits into from
May 5, 2020
Merged

[Metricbeat] Update MSSQL module to use latest library version and fix release tags #17862

merged 8 commits into from
May 5, 2020

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Apr 21, 2020 •
edited
Loading

What does this PR do?

Updates the MSSQL library to its latest version. Remove beta tags from the module as it's considered GA.

Why is it important?

To fix some issues found with SSPI authentication.
We probably missed to set GA tags to the module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@sayden sayden self-assigned this Apr 21, 2020
@andresrc andresrc added [zube]: Inbox [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team and removed [zube]: Inbox labels Apr 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 3
Passed 6808
Skipped 1049
Total 7860

Test errors

Expand to view the tests failures

  • Name: Build and Test / Filebeat x-pack / runTest – nose.failure.Failure

    • Status: FAILED
    • Age: 1
    • Duration: 0
    • Error Details: Cannot subscript an existing Union. Use Union[u, t] instead.

  • Name: Build and Test / Metricbeat x-pack / test_server – test_statsd.Test

    • Status: FAILED
    • Age: 1
    • Duration: 5.615
    • Error Details: 'ascii' codec can't decode byte 0xe2 in position 702041: ordinal not in range(128)

  • Name: Build and Test / Filebeat Windows / test_clean_removed – test_registrar.Test

    • Status: FAILED
    • Age: 1
    • Duration: 10.316
    • Error Details: Timeout waiting for 'cond' to be true. Waited 10 seconds.

Steps errors

Expand to view the steps failures

  • Name: Mage update build test

    • Description: mage update build test

    • Result: FAILURE

    • Duration: 6 min 57 sec<

    • Start Time: 2020-04-30T07:55:17.423+0000

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Result: FAILURE

    • Duration: 10 min 47 sec<

    • Start Time: 2020-04-30T07:57:49.906+0000

  • Name: Mage build test

    • Description: mage build test

    • Result: FAILURE

    • Duration: 9 min 15 sec<

    • Start Time: 2020-04-30T07:55:15.289+0000

  • Name: Make -C generator/_templates/metricbeat test

    • Description: make -C generator/_templates/metricbeat test

    • Result: FAILURE

    • Duration: 1 min 51 sec<

    • Start Time: 2020-04-30T07:58:22.264+0000

Log output

Expand to view the last 100 lines of log output 

[2020-04-30T08:36:59.709Z] >> go test: Integration-zookeeper Test Passed
[2020-04-30T08:36:59.804Z] Recording test results
[2020-04-30T08:37:06.859Z] Stashed 31 file(s)
[2020-04-30T08:37:06.873Z] Archiving artifacts
[2020-04-30T08:37:07.957Z] + curl -sSLo codecov https://codecov.io/bash
[2020-04-30T08:37:08.221Z] + FILE=auditbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f auditbeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=filebeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f filebeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=heartbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f heartbeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=libbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f libbeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=metricbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f metricbeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=packetbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f packetbeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=winlogbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f winlogbeat/build/coverage/full.cov ]
[2020-04-30T08:37:08.221Z] + FILE=journalbeat/build/coverage/full.cov
[2020-04-30T08:37:08.221Z] + [ -f journalbeat/build/coverage/full.cov ]
[2020-04-30T08:37:09.848Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats
[2020-04-30T08:37:10.159Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-04-30T08:37:10.173Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Lint
[2020-04-30T08:37:10.258Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Winlogbeat-oss
[2020-04-30T08:37:10.361Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-04-30T08:37:10.460Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Dockerlogbeat
[2020-04-30T08:37:10.551Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-04-30T08:37:10.645Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Journalbeat-oss
[2020-04-30T08:37:10.778Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Elastic-Agent-Mac-OS-X
[2020-04-30T08:37:10.876Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-04-30T08:37:10.984Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Filebeat-x-pack
[2020-04-30T08:37:11.095Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-04-30T08:37:11.181Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-04-30T08:37:11.266Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-04-30T08:37:11.385Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-04-30T08:37:11.491Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-04-30T08:37:11.587Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Heartbeat-oss
[2020-04-30T08:37:11.668Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-04-30T08:37:11.760Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-04-30T08:37:11.862Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Filebeat-Windows
[2020-04-30T08:37:11.951Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Libbeat-x-pack
[2020-04-30T08:37:12.032Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Auditbeat-Linux
[2020-04-30T08:37:12.116Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-Mac-OS-X
[2020-04-30T08:37:12.199Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Packetbeat-oss
[2020-04-30T08:37:12.295Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-Windows
[2020-04-30T08:37:12.385Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-04-30T08:37:12.494Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Functionbeat-Mac-OS-X-x-pack
[2020-04-30T08:37:12.597Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Heartbeat-Mac-OS-X
[2020-04-30T08:37:12.679Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-04-30T08:37:12.758Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Auditbeat-Mac-OS-X
[2020-04-30T08:37:12.844Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Filebeat-oss
[2020-04-30T08:37:12.931Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Libbeat-oss
[2020-04-30T08:37:13.025Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Heartbeat-Windows
[2020-04-30T08:37:13.141Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-04-30T08:37:13.237Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Functionbeat-Windows
[2020-04-30T08:37:13.325Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Libbeat-crosscompile
[2020-04-30T08:37:13.425Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Libbeat-stress-tests
[2020-04-30T08:37:13.508Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Auditbeat-Windows
[2020-04-30T08:37:13.568Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-04-30T08:37:13.945Z] + cat
[2020-04-30T08:37:13.945Z] + /usr/local/bin/runbld ./runbld-script
[2020-04-30T08:37:13.945Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-04-30T08:37:20.532Z] runbld>>> runbld started
[2020-04-30T08:37:20.532Z] runbld>>> 1.6.11/a66728ff8f4356963772e6e6d2069392fa06acbe
[2020-04-30T08:37:21.914Z] runbld>>> The following profiles matched the job 'Beats/beats-beats-mbp/PR-17862' in order of occurrence in the config (last value wins).
[2020-04-30T08:37:22.854Z] runbld>>> Debug logging enabled.
[2020-04-30T08:37:22.854Z] runbld>>> Storing result
[2020-04-30T08:37:23.114Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-04-30T08:37:23.115Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200430083722-E927E947
[2020-04-30T08:37:23.115Z] runbld>>> Adding system facts.
[2020-04-30T08:37:24.056Z] runbld>>> Adding vcs info for the latest commit:  2b6fd21b4f79bc4e25a5c5b4ba016b76ddb9a95e
[2020-04-30T08:37:24.315Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-04-30T08:37:24.315Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-04-30T08:37:24.315Z] Processing JUnit reports with runbld...
[2020-04-30T08:37:24.315Z] + echo 'Processing JUnit reports with runbld...'
[2020-04-30T08:37:24.885Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-04-30T08:37:24.885Z] runbld>>> DURATION: 24ms
[2020-04-30T08:37:24.885Z] runbld>>> STDOUT: 40 bytes
[2020-04-30T08:37:24.885Z] runbld>>> STDERR: 49 bytes
[2020-04-30T08:37:24.885Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-04-30T08:37:24.885Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats
[2020-04-30T08:37:26.266Z] runbld>>> Storing build metadata: 
[2020-04-30T08:37:26.266Z] runbld>>> Adding test report.
[2020-04-30T08:37:26.266Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862/src/github.com/elastic/beats
[2020-04-30T08:37:27.205Z] runbld>>> Found 72 test output files
[2020-04-30T08:37:28.591Z] runbld>>> Test output logs contained: Errors: 3 Failures: 0 Tests: 7710 Skipped: 890
[2020-04-30T08:37:28.851Z] runbld>>> Storing result
[2020-04-30T08:37:28.851Z] runbld>>> FAILURES: 3
[2020-04-30T08:37:29.790Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-04-30T08:37:29.790Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200430083722-E927E947
[2020-04-30T08:37:29.790Z] runbld>>> Email notification disabled by environment variable.
[2020-04-30T08:37:29.790Z] runbld>>> Slack notification disabled by environment variable.
[2020-04-30T08:37:35.697Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-17862
[2020-04-30T08:37:35.815Z] [INFO] getVaultSecret: Getting secrets
[2020-04-30T08:37:35.878Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-04-30T08:37:36.560Z] + chmod 755 generate-build-data.sh
[2020-04-30T08:37:36.560Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17862/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17862/runs/3 FAILURE 5226723
[2020-04-30T08:37:37.110Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17862/runs/3/steps/?limit=10000 -o steps-info.json
[2020-04-30T08:37:37.661Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-17862/runs/3/tests/?status=FAILED -o tests-errors.json

@sayden
Copy link
Contributor Author

sayden commented May 5, 2020

jenkins runs the tests please

@sayden sayden added the Metricbeat Metricbeat label May 5, 2020
@sayden sayden merged commit 19ea84d into elastic:master May 5, 2020
sayden added a commit to sayden/beats that referenced this pull request May 5, 2020
@sayden
[Metricbeat] Update MSSQL module to use latest library version and fi…
8a246a2 
…x release tags (elastic#17862)

(cherry picked from commit 19ea84d)
@sayden sayden mentioned this pull request May 5, 2020
Merged
6 tasks
@sayden sayden added the v7.8.0 label May 5, 2020
sayden added a commit that referenced this pull request May 5, 2020
@sayden
Cherry-pick #17862 to 7.x: [Metricbeat] Update MSSQL module to use la…
aa2915b 
…test library version and fix release tags (#18237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

Assignees

@sayden sayden

Labels
enhancement Metricbeat Metricbeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sayden @elasticmachine @kvch @andresrc