-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard to the azure database account metricset #17901
Conversation
Pinging @elastic/integrations (Team:Integrations) |
...icbeat/module/azure/_meta/kibana/7/dashboard/Metricbeat-azure-database-account-overview.json
Outdated
Show resolved
Hide resolved
...icbeat/module/azure/_meta/kibana/7/dashboard/Metricbeat-azure-database-account-overview.json
Outdated
Show resolved
Hide resolved
...icbeat/module/azure/_meta/kibana/7/dashboard/Metricbeat-azure-database-account-overview.json
Outdated
Show resolved
Hide resolved
} | ||
} | ||
}, | ||
"title": "Database Account Total Requests [Metricbeat Azure]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think total request can be further split to total requests by StatusCode
or Status
(whichever makes more sense)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added an extra visualization which will filter on status code
"visState": { | ||
"aggs": [], | ||
"params": { | ||
"controls": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it makes sense to extract DatabaseName
dimension as a dedicated input. This will allow to focus the dashboard on a specific database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the database as a filter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* dashboard * add image * update changelog * update dashboard (cherry picked from commit 8d978f6)
What does this PR do?
Adds a dashboard to the azure database account metricset.
Also, removes double metricset name from the
manifest.yml
fileWhy is it important?
It visualizes the most important database account metrics.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Screenshots
Update