-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] allow partial region and zone in googlecloud module config #17913
Conversation
Pinging @elastic/integrations-platforms (Team:Platforms) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to only enable this behavior with a wildcard?
us-*
instead of us-
Good point! I will add that! Thanks @blakerouse !! |
@blakerouse I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you allowed with and without the *
that is nice. Looks like mage update
might need to be called before merging. Otherwise looks good.
Yeah, gcp user who uses their API a lot will probably put region/zone without |
What does this PR do?
This PR is to enable partial region and partial zone in googlecloud module config. User can choose to use wildcard
*
or not. For example:This config will enable data collection from all regions start with
us-west
, which includesus-west1
,us-west2
,us-west3
andus-west4
.Similarly this config will enable data collection from all regions start with
us-
, which includes all regions starts withus-west
,us-east
andus-central
.Why is it important?
This will allow users to not copy paste region/zone names when they want to monitor several regions/zones. If user wants to monitor all regions in both US and Europe, they still need to copy paste but that's very minimum. For example:
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
There are two parts need to be tested. One for regions and another for zones.
Enable googlecloud with this config and you should see metrics collection from all regions start with
us-
.Enable googlecloud with this config and you should see metrics collection from all zones start with
europe-west3-
, which includeseurope-west3-a
,europe-west3-b
andeurope-west3-c
.Related issues