Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17894 to 7.x: Agent push ECS meta to fleet #17921

Merged
merged 5 commits into from
May 4, 2020

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #17894 to 7.x branch. Original message:

What does this PR do?

This PR enhances local metadata sent to fleet on checkin and enroll to conform to ecs format.
It still keeps 3 items it was sending before which will be removed when kibana confirms it does not need it.

Why is it important?

Fixes: #14461

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Elastic-Agent] Agent push ECS meta to fleet (elastic#17894)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Project:fleet)

@michalpristas michalpristas requested a review from ph April 23, 2020 06:44
@ph
Copy link
Contributor

ph commented Apr 24, 2020

@michalpristas as @ruflin noted in the sync this will indeed be a problem we need to send an object to Kibana. I have updated the issues in elastic/kibana#64173 to mention its an object. I believe we have a method in common package that can exploded the keys into multiples nested object.. I haven't found it.

@ph
Copy link
Contributor

ph commented Apr 24, 2020

@michalpristas Can you sync with @nchaulet so we have the appropriate change at the same time?

@michalpristas
Copy link
Contributor Author

@nchaulet ping me when you have a PR ready i will do the change overnight and test it with your branch. we can merge at the same day so snapshots are ok

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 4, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

@michalpristas michalpristas added the Ingest Management:alpha1 Group issues for ingest management alpha1 label May 4, 2020
@michalpristas michalpristas merged commit a1ee6fd into elastic:7.x May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants