Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Fix Cisco ASA 3020** and 106023 messages #17964

Merged
merged 3 commits into from
Apr 27, 2020

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Apr 24, 2020

What does this PR do?

Messages of type 3020** and 106023 are sometimes formatted in a different way. This PR parses all found cases.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@sayden sayden added bug Filebeat Filebeat labels Apr 24, 2020
@sayden sayden self-assigned this Apr 24, 2020
@adriansr adriansr self-requested a review April 24, 2020 13:50
@sayden sayden force-pushed the feature/xp/fb/cisco/asa-106023-fix branch from 955e95f to 2030e29 Compare April 24, 2020 16:52
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Don't forget a changelog entry

@sayden sayden force-pushed the feature/xp/fb/cisco/asa-106023-fix branch from 2030e29 to b486e8e Compare April 27, 2020 08:42
@sayden sayden marked this pull request as ready for review April 27, 2020 08:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@andresrc andresrc added the Team:Services (Deprecated) Label for the former Integrations-Services team label Apr 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@sayden sayden merged commit ae1125d into elastic:master Apr 27, 2020
@AntonioMeireles
Copy link

Hi all,

could you please consider to cherry pick this one to the next 7.6 point release ;-)

thanks in advance and keep the great work!

sayden added a commit to sayden/beats that referenced this pull request Jun 17, 2020
@sayden sayden added the v7.8.0 label Jun 17, 2020
sayden added a commit to sayden/beats that referenced this pull request Jun 17, 2020
@sayden sayden added the v7.9.0 label Jun 17, 2020
sayden added a commit that referenced this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat Team:Services (Deprecated) Label for the former Integrations-Services team v7.8.0 v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants