[Auditbeat] File Integrity ECS update #18012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
Pinging @elastic/siem (Team:SIEM) |
andrewstucki
added
Auditbeat
enhancement
and removed
needs_team
|
WRT the huge diff--looks like running |
leehinman
previously requested changes
Apr 27, 2020
added 2 commits
April 27, 2020 18:41
|
@andrewstucki Can you run |
Ah, looks like that's what I was missing and why the huge diff :) didn't see the custom stuff in |
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
andrewkroh
reviewed
May 5, 2020
andrewkroh
approved these changes
May 5, 2020
andrewstucki
dismissed
leehinman’s stale review
Chatted about the requested change offline, came to consensus and addressed
4 tasks
andrewstucki
pushed a commit
to andrewstucki/beats
that referenced
this pull request
May 5, 2020
* Add extension, mime_type and drive_letter * run go mod vendor * Add ECS categorization fields * mage fmt * Update hash and NOTICE * Update test * Run mage vendor * Add changelog entry * Extract isASCIILetter * switch over to godoc style comment (cherry picked from commit 56ba9d0)
andrewstucki
pushed a commit
that referenced
this pull request
May 5, 2020
* Add extension, mime_type and drive_letter * run go mod vendor * Add ECS categorization fields * mage fmt * Update hash and NOTICE * Update test * Run mage vendor * Add changelog entry * Extract isASCIILetter * switch over to godoc style comment (cherry picked from commit 56ba9d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates ECS fields to be 1.5 (categorization) compatible. It also adds some basic mime-type detection for the given files and a couple of fields that we could have shipped previously.
So, added fields:
event.kindevent.categoryevent.typefile.mime_typefile.extensionfile.drive_letterChecklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues