Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auditbeat] Add system module package dataset ECS categorization fields #18033

Merged
merged 5 commits into from
May 5, 2020
Merged

[Auditbeat] Add system module package dataset ECS categorization fields #18033

merged 5 commits into from
May 5, 2020

Conversation

andrewstucki
Copy link

@andrewstucki andrewstucki commented Apr 28, 2020 •
edited
Loading

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@andrewstucki andrewstucki requested a review from a team as a code owner April 28, 2020 03:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2020
@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2020
leehinman
leehinman requested changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECS categorization stuff looks great.

Looks like we could populate ECS package fields. Think we could add those?

@andrewstucki
Copy link
Author

Thanks for catching that, I had thought that they were being copied to the root field set similar to the host dataset.

@elasticmachine
Copy link
Collaborator

elasticmachine commented May 5, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 189
Skipped 17
Total 206

leehinman
leehinman approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewstucki andrewstucki merged commit 5a308fe into elastic:master May 5, 2020
@andrewstucki andrewstucki deleted the auditbeat-system-package-update branch May 5, 2020 15:25
andrewstucki pushed a commit to andrewstucki/beats that referenced this pull request May 5, 2020
[Auditbeat] Add system module package dataset ECS categorization fiel…
3106ec4 
…ds (elastic#18033)

* [Auditbeat] Add system module package dataset ECS categorization fields

* add changelog entry

* Add ECS package fields

(cherry picked from commit 5a308fe)
@andrewstucki andrewstucki mentioned this pull request May 5, 2020
Merged
3 tasks
andrewstucki pushed a commit that referenced this pull request May 5, 2020
Cherry-pick #18033 to 7.x: [Auditbeat] Add system module package data…
8c80108 
…set ECS categorization fields (#18250)

* [Auditbeat] Add system module package dataset ECS categorization fields (#18033)

* [Auditbeat] Add system module package dataset ECS categorization fields

* add changelog entry

* Add ECS package fields

(cherry picked from commit 5a308fe)

* Fix up changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
Auditbeat enhancement v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Auditbeat] Update Auditbeat system module package dataset to ECS 1.4
4 participants
@andrewstucki @elasticmachine @leehinman @andresrc