Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Revert use of wildcard fields #18066

Merged
merged 1 commit into from
Apr 29, 2020
Merged

[Heartbeat] Revert use of wildcard fields #18066

merged 1 commit into from
Apr 29, 2020

Conversation

andrewvc
Copy link
Contributor

In #17687 new x509 fields were added, and the new wildcard field type was used. Since wildcard fields have been reverted in Elasticsearch 7.x we should revert them here too, to align the 8.x branch of Heartbeat with the 7.x branch. It wouldn't make sense to have the field mappings go out of alignment with a major version change.The 7.x backport of #17687 has this fix rolled in directly, so no backport is needed.

@andrewvc andrewvc added bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team labels Apr 28, 2020
@andrewvc andrewvc requested a review from a team as a code owner April 28, 2020 18:47
@andrewvc andrewvc self-assigned this Apr 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 28, 2020
@andrewvc andrewvc mentioned this pull request Apr 28, 2020
Merged
7 tasks
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 28, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [kuisathaverat commented: jenkins run the tests]

  • Start Time: 2020-04-29T17:31:46.195+0000

  • Duration: 51 min 47 sec (3047498)

  • Commit: f719289

Test stats 🧪

Test Results
Failed 0
Passed 610
Skipped 13
Total 623

blakerouse
blakerouse approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewvc
Copy link
Contributor Author

Jenkins retest

@andrewvc
Copy link
Contributor Author

Jenkins, retest this please

@kuisathaverat
Copy link
Contributor

kuisathaverat commented Apr 29, 2020 •
edited
Loading

jenkins run the tests

@andrewvc
Copy link
Contributor Author

jenkins, retest this

docker failed

@kuisathaverat
Copy link
Contributor

jenkins run the tests

@andrewvc andrewvc merged commit cde17b1 into elastic:master Apr 29, 2020
@andrewvc andrewvc deleted the no-more-wildcards branch April 29, 2020 22:11
@andresrc andresrc removed the needs_team Indicates that the issue/PR needs a Team:* label label May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@andrewvc andrewvc

Labels
bug Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andrewvc @elasticmachine @kuisathaverat @blakerouse @andresrc